Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector theme doesn't update between light and dark theme until another node is selected #81108

Closed
Calinou opened this issue Aug 29, 2023 · 1 comment

Comments

@Calinou
Copy link
Member

Calinou commented Aug 29, 2023

Godot version

4.1.1.stable, 4.2.dev 541674d

System information

Godot v4.2.dev (541674d) - Fedora Linux 38 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 535.98) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

The inspector theme doesn't update between light and dark theme until another node is selected:

For example, after switching from light to dark theme, you initially see this in the inspector:

Screenshot_20230829_100621

If you switch to another node in the inspector (or deselect all nodes then select a node again), section and icon colors will appear correctly (i.e. with darker tones).

Steps to reproduce

  • Select a node in the Scene tree dock.
  • Set the editor theme to Light in the Editor Settings.
  • Notice the sections' and icons' color in the inspector.
  • Select another node (or deselect all nodes then select a node again).
  • Notice how the theme now appears correctly.

Minimal reproduction project

N/A

@YuriSizov
Copy link
Contributor

YuriSizov commented Aug 29, 2023

This is a duplicate of #70356. I plan to look into it at some point, it just needs a bit of theme changed notification handling, but it's not so trivial (see #70381).

@YuriSizov YuriSizov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants