Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Spacing in a nested FontVariation does not work #80907

Closed
kimkanu opened this issue Aug 22, 2023 · 1 comment · Fixed by #80954
Closed

Extra Spacing in a nested FontVariation does not work #80907

kimkanu opened this issue Aug 22, 2023 · 1 comment · Fixed by #80954
Assignees
Milestone

Comments

@kimkanu
Copy link

kimkanu commented Aug 22, 2023

Godot version

4.2.dev3

System information

Godot v4.2.dev3 - macOS 13.4.0 - Vulkan (Mobile) - integrated Apple M1 - Apple M1 (8 Threads)

Issue description

Probably related to #58340

When a FontVariation has a FontVariation in it as a fallback font, Extra Spacing values are overriden by the parent's one. Transforms and Embolden values seem to be fine.

Steps to reproduce

  1. Create a Label.
  2. Create and set a FontVariation as the font of the label node.
  3. Create and set another FontVariation as a fallback font of the font of the label node.
  4. Manipulate Extra Spacing values of the fallback font (such as Glyph) and there are no visible changes. If the parent has changed extra spacing values, then it affects the child fallback font too.
Screenshot 2023-08-23 at 7 44 49

Minimal reproduction project

font_variation_bug.zip

@gu-fan
Copy link

gu-fan commented Jan 27, 2024

in 4.2.1 stable, this issue seems still remains.

chaning spacing_glyph in subresource seems does working after test.

But changing spacing_top or spacing_bottom in subresource does not working.
Screenshot from 2024-01-28 04-42-26
Screenshot from 2024-01-28 04-42-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants