Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoStream calls wrong virtual function on set_paused #79709

Closed
rsubtil opened this issue Jul 20, 2023 · 0 comments · Fixed by #79710
Closed

VideoStream calls wrong virtual function on set_paused #79709

rsubtil opened this issue Jul 20, 2023 · 0 comments · Fixed by #79710

Comments

@rsubtil
Copy link
Contributor

rsubtil commented Jul 20, 2023

Godot version

4.1.dev (latest)

System information

Arch Linux

Issue description

cc @kidrigger

With #62737, the set_paused method is not calling the correct virtual function:

void VideoStreamPlayback::set_paused(bool p_paused) {
GDVIRTUAL_CALL(_is_playing, p_paused);
}

This ends up not being much of an issue because the video player internally stops processing the playback when paused, but I think this is currently wrong nevertheless.

Steps to reproduce

Minimal reproduction project

N/A - Not viable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants