Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme regression in godot 4 #78311

Open
aganm opened this issue Jun 16, 2023 · 2 comments
Open

Theme regression in godot 4 #78311

aganm opened this issue Jun 16, 2023 · 2 comments

Comments

@aganm
Copy link
Contributor

aganm commented Jun 16, 2023

Godot version

4.0+

System information

Godot v4.0+

Issue description

The light themes in godot 4 have regressed from godot 3. I expect the theme 'Solarized Light' in godot 4 to look exactly the way it looked in godot 3.

Steps to reproduce

Open godot, go to the Editor -> Editor Settings -> Interface -> Theme, and change the theme to one of the light themes, either 'Light' or 'Solarized Light'.

Minimal reproduction project

Create a brand new empty project in godot and see the solarized light theme in godot 3:

image

Compare it to godot 4, where the colors are overblown and the minimap has no highlight:

image

I opened PR #78297 to attempt fixing the overblown colors (by simply reducing the negative contrast) until I realized that the minimap hightlight was also missing.

@aganm
Copy link
Contributor Author

aganm commented May 30, 2024

I have to add that there is more wrong with the color themes in Godot 4 than meets the eye. Both Solarized themes have regressed. Dark have regressed a little, but light looks downright wrong. Let me show you:

Solarized Dark:

image

Solarized Light:

image

How say, the Solarized themes in Godot 3, both dark and light, were perfect. And in Godot 4, they were changed away from perfect, and so they look wrong now. Despite my contrast PR and this newer PR to fix the missing minimap highlights, the colors are still wrong. There needs to be a complete revert of the solarized themes in Godot 4 to what they were in Godot 3.

It's kind of subtle but it's also evident to my Solarized used eyes that Godot 4 solarized themes are way off. It's made very very evident when I have my code editor (which uses a correct solarized theme), side by side with Godot 3, where Godot 3 matches perfectly. I can use the pipette and compare the matching colors between my editor and Godot 3, and the colors match perfectly. Godot 4 is all wrong, lights are too bright, or too dark, and darks are too bright, or too dark, tones are off as well.

@aganm aganm changed the title Light themes regression in godot 4 Themes regression in godot 4 (both light and dark) May 30, 2024
@aganm
Copy link
Contributor Author

aganm commented May 30, 2024

I was able to ultimately fix Solarized Dark by simply reverting the theme settings right back to what they were in Godot 3. #92542

Unfortunately I didn't have as much luck with Solarized Light, I probably have to revert more stuff as well but I'm not sure what.

@aganm aganm changed the title Themes regression in godot 4 (both light and dark) Solarized themes regression in godot 4 (both light and dark) May 31, 2024
@aganm aganm changed the title Solarized themes regression in godot 4 (both light and dark) Themes regression in godot 4 (both light and dark) May 31, 2024
@aganm aganm changed the title Themes regression in godot 4 (both light and dark) Theme regression in godot 4 (both light and dark) May 31, 2024
@aganm aganm changed the title Theme regression in godot 4 (both light and dark) Theme regression in godot 4 May 31, 2024
@KoBeWi KoBeWi modified the milestones: 4.3, 4.x Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants