Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch rename won't check for duplicate unique name #78291

Closed
ajreckof opened this issue Jun 15, 2023 · 2 comments · Fixed by #78292
Closed

Batch rename won't check for duplicate unique name #78291

ajreckof opened this issue Jun 15, 2023 · 2 comments · Fixed by #78292

Comments

@ajreckof
Copy link
Member

Godot version

v4.1.beta.custom_build [c0d8d91]

System information

macOS 13.3.0 - Vulkan (Forward+) - integrated Apple M1 Pro - Apple M1 Pro (8 Threads)

Issue description

When batch renaming nodes it won't check for already used unique name. This will lead to the unique name being revoked with those warning.
Capture d’écran 2023-06-15 à 23 56 06
Expected behavior would be a popup similar to this one being fired when doing the same rename with basic rename and preventing node rename.
Capture d’écran 2023-06-15 à 23 56 21

Steps to reproduce

  1. create a scene with a root two child and one grand child
  2. make unique name the scond child and the grand child
  3. batch rename the two child to "Node"
  4. see the warning and the unique name being revoked

Minimal reproduction project

Test.zip
with MRP start at step 3

@Calinou
Copy link
Member

Calinou commented Jun 22, 2023

I've tried to reproduce this issue locally on v4.1.beta.custom_build [b6ba664], but I don't see the batch rename dialog when selecting a child and a grandchild

image

@ajreckof
Copy link
Member Author

yeah this is why I precisely told two add two child and one grand child this is another bug #76069.
When I put to rename the two child I meant the root's child

@akien-mga akien-mga modified the milestones: 4.1, 4.2 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants