Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling top-level does not update 2D editor viewport #76205

Closed
KoBeWi opened this issue Apr 18, 2023 · 2 comments · Fixed by #87343 · May be fixed by #87316
Closed

Toggling top-level does not update 2D editor viewport #76205

KoBeWi opened this issue Apr 18, 2023 · 2 comments · Fixed by #87343 · May be fixed by #87316

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Apr 18, 2023

Godot version

4.0.2

System information

Windows 10 x64

Issue description

godot.windows.editor.dev.x86_64_uFba4bht5k.mp4

Steps to reproduce

  1. Add Sprite2D
  2. Toggle its top_level
  3. Notice how the gizmo rectangle stays in the old position until you hover 2D editor

Minimal reproduction project

N/A

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Jan 15, 2024

IMO it shouldn't move at all. Due to this bug, and because it's jarring. Especially once you start adding rotation and scale, the item could just teleport completely out of the viewport and could be difficult to find if you don't know the hotkeys.

It should, stay in place and update transform relative to global, which is what this PR for 3D is doing: #87100

@ryevdokimov
Copy link
Contributor

ryevdokimov commented Jan 18, 2024

I added two different solutions that should solve this problem depending on timeframes, compatibility, or general direction the Godot team wants to approach this. If you have time to review it, it would be appreciated.

@YuriSizov YuriSizov added this to the 4.3 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment