Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic Dependencies in shader freeze #75813

Closed
the-ssd opened this issue Apr 8, 2023 · 3 comments · Fixed by #77608
Closed

Cyclic Dependencies in shader freeze #75813

the-ssd opened this issue Apr 8, 2023 · 3 comments · Fixed by #77608

Comments

@the-ssd
Copy link

the-ssd commented Apr 8, 2023

Godot version

4.0.1(flatpak)

System information

Linux openSUSE

Issue description

Cyclic Dependencies in shader result in infinite loop

Steps to reproduce

Create 'main' shader that includes other shader, let's say inc_me1 and inc_me2 if 'inc_me1' that includes 'main' shader and 'inc_me2' includes 'inc_me1'. It results in a freeze.

Minimal reproduction project

Shader dependency.zip
uncomment include, and the editor will freeze and crash

@Chaosus
Copy link
Member

Chaosus commented May 8, 2023

cc @bitsawer

@Chaosus
Copy link
Member

Chaosus commented May 8, 2023

@the-ssd Please attach the minimal reproduction project

@Chaosus Chaosus added this to the 4.1 milestone May 8, 2023
@the-ssd
Copy link
Author

the-ssd commented May 23, 2023

@Chaosus done, sorry that it took so long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants