Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Files are newer on disk" warnings after shift to Daylight Savings Time #74816

Closed
guitarmike opened this issue Mar 12, 2023 · 3 comments · Fixed by #74830
Closed

"Files are newer on disk" warnings after shift to Daylight Savings Time #74816

guitarmike opened this issue Mar 12, 2023 · 3 comments · Fixed by #74830

Comments

@guitarmike
Copy link

Godot version

4.0

System information

Windows 10

Issue description

Last night we shifted to Daylight Savings Time in the US. I left Godot running overnight. When I awoke, there was a dialog on screen listing many of the files in the project and saying that the files were newer on disk. This hasn't happened before so I assume it is the result of clocks moving forward overnight.

Steps to reproduce

N/A - see above.

Minimal reproduction project

N/A

@AThousandShips
Copy link
Member

It seems this is a windows "feature", the _wstat method does not respect the epoch and does something weird with DST, will look into alternatives in Windows but think this is just a "feature" that windows has to deal with

@ievr
Copy link

ievr commented Mar 31, 2024

Could we get this reviewed for the next DST changeover in November? We had a gamejam and this can cause data loss if there are unsaved files at 3AM.

@AThousandShips
Copy link
Member

There's a PR open and if you're able to test it please do to help get it merged :)

@AThousandShips AThousandShips modified the milestones: 4.x, 4.4 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants