Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationTree forces properties to be at value in RESET track in UPDATE_DISCRETE and UPDATE_TRIGGER mode #69066

Closed
zacryol opened this issue Nov 23, 2022 · 12 comments

Comments

@zacryol
Copy link
Contributor

zacryol commented Nov 23, 2022

Bugsquad Edited: This problem occurs in beta6, but has already been addressed in master. There is no more need to report.


Godot version

4.0.beta6

System information

Linux

Issue description

When using multiple animations with an AnimationTree, it appears as though the RESET track is prioritized above all others.
The included MRP shows an example: The two animations, one to set visible and one to set the flip_v, do not appear to play at all, as the value is being forced. Changing the value in the RESET track will change the value it's stuck at. The spin animation works as long as it's playing (as it gets set every frame in a more continuous manner), but as soon as that animation ends, it's back to the RESET track value.

Steps to reproduce

Make an AnimationTree that uses animations that have values in the RESET track.

Minimal reproduction project (updated)

anim-bug-mrp.zip

@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

This is a regression, as I did not have this problem in beta4 (and also in beta5).

@KoBeWi
Copy link
Member

KoBeWi commented Nov 23, 2022

I opened the project and not sure what's the problem. How do you even play the animations?

@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

The animations are played by the AnimationTree and StateMachine.
The spin animation can be played by clicking it in the editor.

It's mainly for in editor, there's not code to change it at runtime.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 23, 2022

The animations are played automatically by the AnimationTree and StateMachine.

Doesn't look like it.

The spin animation can be played by clicking it in the editor.

There is no spin animation.

It would be helpful if you recorded some video maybe.

@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

I may have added that after zipping the project

@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

anim-bug.mp4

@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

And for reference, this is what it should do (and does do in beta4)

anim-not-bug.mp4

@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

I also checked beta 5, and it works correctly there.

@TokageItLab
Copy link
Member

TokageItLab commented Nov 23, 2022

I cannot reproduce it too. I think this problem already has been fixed in #68993.

@TokageItLab
Copy link
Member

Oh, unfortunately that fix seems to have been merged right after the beta6 build was created, please wait for beta7.

@TokageItLab TokageItLab changed the title AnimationTree forces properties to be at value in RESET track AnimationTree forces properties to be at value in RESET track in UPDATE_DISCRETE and UPDATE_TRIGGER mode Nov 23, 2022
@TokageItLab TokageItLab added this to the 4.0 milestone Nov 23, 2022
@TokageItLab
Copy link
Member

I consider this issue slightly bigger, so I pin this on issue board until beta7.

@TokageItLab TokageItLab pinned this issue Nov 23, 2022
@zacryol
Copy link
Contributor Author

zacryol commented Nov 23, 2022

Oh, unfortunately that fix seems to have been merged right after the beta6 build was created, please wait for beta7.

Yeah, I just built from master (f05a55e) and it seems to work there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants