-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IPHONEOS_DEPLOYMENT_TARGET from 10.0 to 11.0 in 3.5.1 and greater #68720
Comments
cc @bruvzg |
I'm surprised Xcode eventually blocks you from using old iOS versions as a baseline... iOS 10 should still be able to run Godot 3.x projects. That said, for Godot 4.0, the requirement will probably have to be increased to iOS 11.0 at least. As of writing, the latest iOS version is 16.x, so it shouldn't affect too many users. |
I am also surprised this pops up. Xcode 14.0.1 / Godot 3.5.1 stable successfully exports much more than an Hello World project. I guess if that was not the case we would have raised the issue loudly before. |
I can confirm Xcode 14.1 warns 10.0 is an invalid setting, although it still allows the application to build. |
Yes, the exact error Xcode gives is:
|
The only officially supported versions are 15 and 16. So dropping support for the iOS 10 is expected, some minor updates for the Xcode 12 did the same for iOS 9. In the 4.0 it's already set to |
I'm using Godot 3.5.1 with Xcode 14.2 (macOS 12.7.4) and I get the same error.
It's a minor issue, because once you open the Xcode project it opens a pop-up telling you to upgrade some settings, it automatically fixes it for you and that's it, but maybe it would be a good idea to add a new parameter to the Export settings for iOS in Godot? To specify the "(minimum) deployment target" so we don't get that warning? |
Yes, bumping the minimum iOS version is usually taken care of by @bruvzg (Godot's official iOS guru) but there are plenty of minor issues out there lingering around that eventually get fixed for 3.x, like this one for example. As long as it is not blocking nor presents a significant inconvenience - it's okay. But you are right that it would have been better if the Wolrd we're living in was ideal and we really had 0 warnings and 0 errors on every compile that we do with Xcode, including zero warnings about translation projects and what not. But one eventually accepts the fact that the World we're living in is never perfect so we boringly swallow a few orange Xcode warnings every time we compile a project without bothering to make a big deal out of it. ;-) usually in such cases, you're very welcome to contribute a patch. |
It is there in 4.x: godot/platform/ios/export/export_plugin.cpp Line 166 in f6a78f8
Might be worth backporting to 3.6 as well. Min. version is already bumped to |
If it's not much work for you @bruvzg , I think it would be a good addition to 3.x. |
Godot version
3.5.1
System information
n/a
Issue description
The generated iOS project build files sets IPHONEOS_DEPLOYMENT_TARGET as 10.0, which is invalid in the latest versions of Xcode. Recommend 11.0 is set as default.
Steps to reproduce
Export any hello world project to iOS
Minimal reproduction project
Export any hello world project to iOS
The text was updated successfully, but these errors were encountered: