Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations with awkward lengths (more than 2-3 decimal places) ignore keys on the last frame #66631

Closed
LakshayaG73 opened this issue Sep 29, 2022 · 4 comments

Comments

@LakshayaG73
Copy link

Godot version

4.0 beta

System information

Win 11

Issue description

Animations that have slightly awkward lengths have issues where the keys on the last frame are not executed.

These keys can belong to value tracks, or even function tracks in my experience.

I'm not certain that this only pertains to animations with specific lengths, but this is the only pattern I have found. As I don't see this issue in all animations.

The workaround is to increase the length of the animation slightly, shift the key slightly on the track, or delete the track and add it again (in some cases).

Steps to reproduce

Create animation in Animation Player
Set an awkward length -> 5 frames at 24 fps
Add some keys on different tracks on the last frame.
Check if (all) the keys are executed

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Sep 30, 2022

This is likely a floating-point precision issue, or a frame pacing issue (60 FPS only has 16 ms resolution). Can you reproduce this with V-Sync disabled and a small window size (to reach high FPS)? Enable Print FPS in the project settings to also view the FPS.

Also, please upload a minimal reproduction project to make this easier to troubleshoot.

@TokageItLab
Copy link
Member

May be related by #64644.

@Calinou
Copy link
Member

Calinou commented Oct 29, 2022

Duplicate of #64644.

@Calinou Calinou closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2022
@TokageItLab
Copy link
Member

Maybe this is related to #59784 instead of #64644, but I can't determine since MRP and details are lacking on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants