Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan Clustered: ReflectionProbes have no effect on VisualInstances not in their cull mask layers #66389

Closed
jtnicholl opened this issue Sep 25, 2022 · 4 comments

Comments

@jtnicholl
Copy link
Contributor

Godot version

v4.0.beta.custom_build [f74491f]

System information

Linux (Fedora 36)

Issue description

If a VisualInstance3D is not in any of a ReflectionProbe's cull layers, the probe has no effect on it.
What is supposed to happen is that the visual instance doesn't appear in the probe's reflection, but it is still effected by the probe, both showing its reflections and ambient light settings. This is what happens in 3.x and the forward mobile renderer.
The ball on the left is inside the probe's cull layers, the ball on the right is not. It's even more noticeable with a metallic material.
refprobe

Steps to reproduce

  1. Add a reflection probe to a scene with some other nodes
  2. Remove a layer from its cull layers
  3. Remove some nodes in the scene from the same render layer

Minimal reproduction project

RefProbMasks.zip
Same scene from the image.

@mrjustaguy
Copy link
Contributor

See #50196

@Chaosus Chaosus added this to the 4.0 milestone Sep 25, 2022
@Chaosus Chaosus moved this to To Assess in 4.x Priority Issues Sep 25, 2022
@Chaosus Chaosus moved this from To Assess to Todo in 4.x Priority Issues Sep 25, 2022
@jtnicholl
Copy link
Contributor Author

I didn't see that PR or its linked issue while searching. Probably because the title makes it sound like a feature proposal instead of a bug. The description even more so.
So I guess this is technically a duplicate of #50195 but I'm going to leave it open because I think this is a much better description of the bug.

@clayjohn
Copy link
Member

Closing as duplicate of #50195

Its much better for us to have one issue per bug so that everything can be tracked in one place.

@clayjohn clayjohn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2022
@clayjohn clayjohn removed this from the 4.0 milestone Sep 26, 2022
@jtnicholl
Copy link
Contributor Author

Its much better for us to have one issue per bug so that everything can be tracked in one place.

I'm aware, I was suggesting to close the other issue instead. It describes a bugfix as a feature proposal and its title doesn't make sense, the latter being why I didn't see it when I searched to check if the bug was already reported.
If you're not going to do that, then at least the other issue should be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants