Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Help: Empty results list when nothing is in the filter box #62508

Closed
me2beats opened this issue Jun 29, 2022 · 6 comments · Fixed by #62524
Closed

Search Help: Empty results list when nothing is in the filter box #62508

me2beats opened this issue Jun 29, 2022 · 6 comments · Fixed by #62524

Comments

@me2beats
Copy link

Godot version

3.5rc, 4.0alpha

System information

windows

Issue description

I just wanted get a list of all signals in all classes.
So I opened Search help, wasn't ready for surprises.
I selected "signals only" - the results list was so empty.
Same with "properties" , not "classes" this is kinda outstanding.

image

Steps to reproduce

Press F1 to open Search Help.
Set to Signals Only / something else.
You will see an empty list of signals.
Tested with 3.5, 4.0, windows.

Minimal reproduction project

No response

@Phischermen
Copy link
Contributor

This appears to be the same behavior in Godot 3.3 too. I'm guessing it's the same in Godot 3.4 too. I notice too that at least 2 characters need to be typed before results start to show. I think I would also prefer seeing a full list of properties, signals, and methods when the search bar is empty.

@AThousandShips
Copy link
Member

I can take a look at this if that's okay

@AThousandShips
Copy link
Member

Additionally, constructors and operators do not show up at all, even with searches, this seems to be from #53452 where constructors and operators were separated from other methods but help search did not get updated to reflect this

I'll take a look at a solution to this

@AThousandShips
Copy link
Member

I've worked out a change for this and I'll open a PR for it if this is an enhancement that's wanted, I'm new to contributing so not sure exactly what the workflow is (and didn't manage to figure it out from the documentation sorry) so not wanting to open a PR if it's the wrong thing to do

@Phischermen
Copy link
Contributor

Awesome! Have you seen this [page?] (https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html) It lists the steps for making a PR.

@AThousandShips
Copy link
Member

I have! And been learning the ropes for that! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants