Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Current Project should open in current console #58309

Open
dweremeichik opened this issue Feb 19, 2022 · 2 comments
Open

Reload Current Project should open in current console #58309

dweremeichik opened this issue Feb 19, 2022 · 2 comments

Comments

@dweremeichik
Copy link

Godot version

v3.4.2.stable.official [45eaa2d]

System information

Windows 10

Issue description

I normally use multiple tabs in Windows Terminal and run Godot using godot -e in one of them so I can monitor it. Occasionally I need to reload a project. Doing so by clicking "Reload Current Project" ends up disowning the process from the terminal you opened it in and opens a new command prompt.

Steps to reproduce

  • In your terminal of choice, open Godot with godot -e
  • Once in a project click "Reload Current Project"
  • Godot will reopen with a new command prompt/terminal instead of your original terminal.

Minimal reproduction project

No response

@dweremeichik
Copy link
Author

dweremeichik commented Feb 19, 2022

I see that this would likely need to be handled in CreateProcessW but it is not immediately apparent to me if this is actually a possibility with the current structure.

Edit:
Yes it should be according to CreateProcessW

If the dwCreationFlags parameter has a value of 0:
The process inherits both the error mode of the caller and the parent's console.

Perhaps CREATE_NEW_CONSOLE shouldn't be getting called when we already have a console open (maybe if we manually call something like godot -e).

@dweremeichik
Copy link
Author

Possibly fixed in 3.5 by #55987

Need to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants