Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl_window_make_current is not set to override. #56456

Closed
fire opened this issue Jan 3, 2022 · 1 comment
Closed

gl_window_make_current is not set to override. #56456

fire opened this issue Jan 3, 2022 · 1 comment

Comments

@fire
Copy link
Member

fire commented Jan 3, 2022

Godot version

4.0 dev 7b02ec7

System information

Win 10

Issue description

virtual void gl_window_make_current(DisplayServer::WindowID p_window_id);

gl_window_make_current is not set to override.

This causes scons dev=yes to fail.

Steps to reproduce

Build with scons.

scons dev=yes

b"In file included from platform\\windows\\display_server_windows.cpp:31:\r\nplatform\\windows/display_server_windows.h:480:15: error: 'gl_window_make_current' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\r\n        virtual void gl_window_make_current(DisplayServer::WindowID p_window_id);\r\n                     ^\r\n.\\servers/display_server.h:302:15: note: overridden virtual function is here\r\n        virtual void gl_window_make_current(DisplayServer::WindowID p_window_id);\r\n                     ^\r\nplatform\\windows\\display_server_windows.cpp:441:2: warning: touchscreen not working [-W#warnings]\r\n#warning touchscreen not working\r\n ^\r\n1 warning and 1 error generated.\r\n"

Minimal reproduction project

Not applicable.

@TechnoPorg
Copy link
Contributor

This was fixed in #56012.

@Calinou Calinou closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants