Disable unused parts of Basis Universal to improve build times and reduce binary sizes

[Calinou]

Godot version

4.0.dev (28174d5)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 470.74)

Issue description

Right now, all the default features of Basis Universal are enabled at compile-time.

• BASISD_SUPPORT_ASTC
• BASISD_SUPPORT_UASTC
• BASISD_SUPPORT_PVRTC1 (if Remove support for PVRTC texture encoding and decoding #56309 is merged)
• BASISD_SUPPORT_PVRTC2 (if Remove support for PVRTC texture encoding and decoding #56309 is merged)

The above defines could all be set to 0 so that they are disabled at compile-time. Godot does not currently support displaying those compression formats, so they're of no use in the transcoder. (ASTC support may be considered in a future Godot release, but not for 4.0 as hardware adoption will still be too low when 4.0 is released.)

See https://github.com/BinomialLLC/basis_universal/wiki/How-to-Use-and-Configure-the-Transcoder#shrinking-the-transcoders-compiled-size.

Steps to reproduce

N/A

Minimal reproduction project

N/A

[Calinou]

I've tried my hand at it: https://github.com/Calinou/godot/tree/basis-universal-disable-unused-features

The code compiles successfully, but the linking stage fails. Any ideas?

Linking Program bin/godot.linuxbsd.tools.64.llvm ...
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_astc_weights4
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_astc_weights5
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::astc_is_valid_endpoint_range(unsigned int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::astc_get_levels(int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::unquant_astc_endpoint_val(unsigned int, unsigned int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_astc_unquant
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_astc_unquant
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::g_astc_weights5
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_bc7enc.linuxbsd.tools.64.llvm.o): basist::astc_get_levels(int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_comp.linuxbsd.tools.64.llvm.o): basisu::uastc_rdo(unsigned int, basist::uastc_block*, basisu::color_rgba const*, basisu::uastc_rdo_params const&, unsigned int, basisu::job_pool*, unsigned int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_comp.linuxbsd.tools.64.llvm.o): basisu::encode_uastc(unsigned char const*, basist::uastc_block&, unsigned int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_table_anchor_index_third_subset_1
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_table_anchor_index_third_subset_2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_partition3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_table_anchor_index_second_subset
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_partition2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights4
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::unpack_uastc(basist::uastc_block const&, basist::color32*, bool)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights2
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights3
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights4
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basist::g_bc7_weights4
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basisu::pvrtc4_swizzle_uv(unsigned int, unsigned int, unsigned int, unsigned int)
mold: error: undefined symbol: modules/libmodule_basis_universal.linuxbsd.tools.64.llvm.a(basisu_gpu_texture.linuxbsd.tools.64.llvm.o): basisu::pvrtc4_image::get_pixel(unsigned int, unsigned int, unsigned int) const
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [bin/godot.linuxbsd.tools.64.llvm] Error 1
scons: building terminated because of errors.

[akien-mga]

We now support and need ASTC, but indeed PVRTC could be disabled. I'm not sure the build time and binary size gains would be significant, but why not.

[fire]

Since #56309 was merged and ASTC is required. This is closable?

[Calinou]

Since #56309 was merged and ASTC is required. This is closable?

This issue is still relevant; see #85321.