Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSG node gizmos are outdated after reparenting nodes to a CSGCombiner #55833

Closed
ellogwen opened this issue Dec 11, 2021 · 6 comments
Closed

CSG node gizmos are outdated after reparenting nodes to a CSGCombiner #55833

ellogwen opened this issue Dec 11, 2021 · 6 comments

Comments

@ellogwen
Copy link

Godot version

v3.4.stable.arch_linux

System information

OpenGL ES 3.0 Renderer: AMD Radeon Vega 8 Graphics (RAVEN, DRM 3.40.0, 5.10.79-1-MANJARO, LLVM 13.0.0)

Issue description

When I place a CSGCombiner and add any CSG node type as children, the combiner does not update it's mesh after you switched tabs.

image

This is odd, I work with csg a lot, why can I reproduce it so easily now and now notice it earlier? I will reboot to see if its a memory issue or something.

Steps to reproduce

Create a new Project
Add a CSGCombiner to the scene
Add any CSG Node as child of that combiner
Change some settings of that child, see the mesh update
Switch tab to another 3d scene
Switch back
Change settings of the children
Mesh does not update anymore until you reparent the CSGCombiner

Minimal reproduction project

csg-combiner-bug.zip

Video:
https://youtu.be/cx8CTbt_Wi4

@ellogwen
Copy link
Author

Nah, still the same after reboot.

@Calinou
Copy link
Member

Calinou commented Dec 11, 2021

Looking at the video, only the gizmos seem to be outdated, not the CSG mesh itself.

@Calinou Calinou changed the title CSGCombiner does not update the shape when switching tabs CSG node gizmos are outdated after reparenting nodes to a CSGCombiner Dec 11, 2021
@ellogwen
Copy link
Author

ellogwen commented Dec 11, 2021

On the video, right at the end, you can barely see that there are faint blue lines next to the rendered mesh. Just leave this here because it is barely visible. This is the actual mesh, translated to the right, the small one at the end is still wrong. Don't know if related

@ellogwen
Copy link
Author

Only the gizmos seem to be outdated, not the CSG mesh itself.

Yeah you are right. wen saving the scene and reopen it, the mesh is correct. So seems to be a visual issue then, I guess

@cdemirer
Copy link
Contributor

cdemirer commented Dec 12, 2021

Not the same issue but might be related: #54445

@akien-mga
Copy link
Member

Fixed by #58938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants