ring_buffer<T> breaks builds on c++20 (and versions < c++14)

[sehoffmann]

Godot version

3.x, 4.x

System information

n/a

Issue description

godot/core/templates/ring_buffer.h

Line 214 in d18cbdf

RingBuffer<T>(int p_power = 0) {

Obviously this is very odd code (didn't even know that this is even valid). However, apparently this was accidentally introduced in C++14. They remove it in C++20 now, which means that the coder works only with c++14 <= version < c++20. See https://stackoverflow.com/questions/63513984/can-class-template-constructors-have-a-redundant-template-parameter-list-in-c2

This code is both in 4.x as well as 3.x

Steps to reproduce

n/a

Minimal reproduction project

No response

[ShlomiRex]

Tried compiling godot with MSVC c++ but get tons of errors, spesifically 'Compiler Error C2666': https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-2/compiler-error-c2666?view=msvc-160.
I added some operator== functions, it fixes it, but it keeps on getting more and more (basically too much for me to handle).
Perhaps we can withhold this untill we have C++20 support.

[sehoffmann]

Perhaps we can withhold this untill we have C++20 support.

Only the <T> need to be removed from both the ctor and dtor.

[akien-mga]

Fixed by #91208.