Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking StyleBoxTexture in Theme editor brings up TextureRegion editor #50542

Open
timothyqiu opened this issue Jul 17, 2021 · 1 comment
Open

Comments

@timothyqiu
Copy link
Member

Godot version

3.4.beta1

System information

macOS 11.4

Issue description

After creating a new stylebox override in the new Theme editor, clicking the created StyleBoxTexture brings up the TextureRegion editor, which is quite annoying.

This won't happen again if you then switch to the theme editor by clicking "Theme" in the bottom bar. But will still happen if you switch to the theme editor by clicking history buttons in the Inspector panel.

This is similar to #29873, but the new theme editor tab won't disappear in this case.

This does not happen in 4.0.

Steps to reproduce

  1. Open the Godot editor
  2. Create a Theme resource
  3. Pick a class that has customizable stylebox
  4. Click the button with plus icon to add an override, and create a StyleBoxTexture resource for it
  5. Click the newly created stylebox resource
    • ... and it switches to the TextureRegion editor
  6. Go back to the theme editor by clicking the "Go to the previous edited object in history." button in the Inspector
  7. Click the stylebox resource again
    • ... and it switches to the TextureRegion editor again
  8. Go back to the theme editor by clicking "Theme" in the bottom bar
  9. Click the stylebox resource again
    • ... and it works fine, won't be brought to the TextureRegion editor

Minimal reproduction project

No response

@YuriSizov
Copy link
Contributor

YuriSizov commented Aug 2, 2021

This does not happen in 4.0.

I think that in master there were some improvements to having multiple editors at the same time which cannot be ported back to 3.x. (Edit: Though maybe I was thinking about #45085)

But otherwise, this is an intended behavior. Not sure what you would like to see act differently with the theme editor specifically.

but the new theme editor tab won't disappear in this case.

Yes, because I've made some non-Theme types "supported" by the new theme editor just so that it doesn't close when you select a subresource, like a StyleBox.

@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@KoBeWi KoBeWi modified the milestones: 3.5, 3.x Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants