Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: LightmapGI energy not implemented (unlike BakedLightmapData in 3.x) #49968

Open
Tracked by #56033
Calinou opened this issue Jun 28, 2021 · 0 comments
Open
Tracked by #56033

Vulkan: LightmapGI energy not implemented (unlike BakedLightmapData in 3.x) #49968

Calinou opened this issue Jun 28, 2021 · 0 comments
Labels
enhancement topic:rendering topic:3d
Milestone
4.x

Comments

@Calinou
Copy link
Member

Calinou commented Jun 28, 2021 •
edited
Loading

See also #49935 and #50568.

Godot version

4.0.dev (659178e)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 465.31)

Issue description

In the master branch, baked lightmaps cannot have their intensity modulated by an Energy parameter. This is available in 3.x, and it affects both the lightmap itself and dynamic object probes there.

Adjusting the lightmap's energy is not physically accurate, but it can be used for special effects, last-minute corrections or to adjust world brightness without any performance cost (unlike the Adjustments section in Environment).

Steps to reproduce

Look for a lightmap energy property (as is present in 3.x).

Minimal reproduction project

test_lightmap_normalmap.zip
@Calinou Calinou added this to the 4.0 milestone Jun 28, 2021
@Calinou Calinou mentioned this issue Jun 28, 2021
Closed
@Calinou Calinou changed the title Vulkan: LightmapGI energy not implemented (unlike BakedLightmap in 3.x) Vulkan: LightmapGI energy not implemented (unlike BakedLightmapData in 3.x) Jun 29, 2021
@Calinou Calinou mentioned this issue Jul 17, 2021
Open
@Calinou Calinou mentioned this issue Dec 17, 2021
Open
@Calinou Calinou mentioned this issue Oct 6, 2022
Merged
@clayjohn clayjohn modified the milestones: 4.0, 4.x Feb 22, 2023
@clayjohn clayjohn mentioned this issue Mar 3, 2023
Merged
@Calinou Calinou mentioned this issue Sep 20, 2023
Closed
@Calinou Calinou mentioned this issue Oct 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement topic:rendering topic:3d
Projects
None yet
Milestone
4.x
Development

No branches or pull requests
2 participants
@Calinou @clayjohn