Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: StandardMaterial3D specular modes are off by one #49841

Closed
Tracked by #56333
Calinou opened this issue Jun 22, 2021 · 1 comment
Closed
Tracked by #56333

Vulkan: StandardMaterial3D specular modes are off by one #49841

Calinou opened this issue Jun 22, 2021 · 1 comment

Comments

@Calinou
Copy link
Member

Calinou commented Jun 22, 2021

Godot version

4.0.dev (6d98f84)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 465.31)

Issue description

StandardMaterial3D specular modes are off by one compared to what you configure in the inspector.

From left to right, I configured the spheres to use Toon, Phong, Blinn and SchlickGGX.

However, from left to right, they appear to be Disabled, Toon, Phong, (Blinn or SchlickGGX). There's likely an off-by-one error in the shader since parts of it were removed for performance reasons.

image

Steps to reproduce

Create StandardMaterial3D, set the albedo to black and tweak the specular mode.

Minimal reproduction project

tests/3d/test_standard_material_3d_opaque.tscn from https://github.com/Calinou/godot-rendering-tests

@clayjohn
Copy link
Member

This was fixed at some point! I can't reproduce in RC3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants