Error "getornull: Condition !id_map.has(p_rid.get_data())" showing up when changing property of a sprite 3D with a deleted light source

[Pantabrah]

The error message :

getornull: Condition "!id_map.has(p_rid.get_data())" is true. Returned: __null
   At: ./core/rid.h:160 @ getornull()

Is displayed everytime you change a property of a sprite3D (Like the current frame or the opacity) that has been touched by a light source that no longer exist until another light source touch it.
Even if the sprite is out of range of the light source when it get removed, the moment the light stop existing the error will begin showing up.
Only spotlights or omnilights trigger the problem.

Tested on 3.3-stable as well as on a 3.2.4RC1 that was laying around.

Here is a small project displaying the issue :

test_light.zip

[Calinou]

Can you reproduce this after disabling BVH in the Project Settings?

[Pantabrah]

Yes, disabling BVH does not solve the issue.

[akien-mga]

Tested on the lastest stable release as well as on a 3.2.4RC1 that was laying around.

Please clarify what "latest stable release" means, in a few weeks time this will be different from what you mean today and contributors shouldn't have to look up the chronology of releases to infer this information. (That's why the issue template you deleted asks for this explicitly.)

[akien-mga]

Tested a few releases, this appears to be a regression in 3.2.3-stable (compared to 3.2.2-stable which does not produce the error). Happens as early as 3.2.3-beta1.

Probably related to #39867.

[clayjohn]

Error is coming from this line:

godot/drivers/gles3/rasterizer_scene_gles3.cpp

Line 1756 in 48d7eff

LightInstance *li = light_instance_owner.getornull(lights[i]);

Still can't figure out why Sprite3D is triggering the error.

[akien-mga]

Fixed by #48499.