Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: OmniLight3D/SpotLight3D projectors not reimplemented yet #45733

Closed
Calinou opened this issue Feb 5, 2021 · 0 comments · Fixed by #50402
Closed

Vulkan: OmniLight3D/SpotLight3D projectors not reimplemented yet #45733

Calinou opened this issue Feb 5, 2021 · 0 comments · Fixed by #50402
Assignees
Milestone

Comments

@Calinou
Copy link
Member

Calinou commented Feb 5, 2021

Godot version: master 80a4d0f

OS/device including version: Fedora 33, GeForce GTX 1080 (NVIDIA 460.32.03)

Issue description:

#45023 removed light projector support to improve shader occupancy, letting the GPU make better use of parallelism.

reduz said that light projectors should be reimplemented, but placed behind an opt-in project setting. The reason for doing this is that projector support increases the forward renderer's base cost, and therefore will slow down rendering even if no projectors are used at all.

Steps to reproduce: Look for light projectors in the master branch 🙂

Minimal reproduction project: N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants