Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom editor shortcuts get corrupted #36839

Closed
KoBeWi opened this issue Mar 5, 2020 · 6 comments
Closed

Custom editor shortcuts get corrupted #36839

KoBeWi opened this issue Mar 5, 2020 · 6 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Mar 5, 2020

Godot version:
da05ca6

Issue description:
When you open the editor, the shortcuts you have assigned stop working. They appear as empty strings in the settings panel and upon inspecting the editor_settings-4.tres you can see that the shortcuts exist, but are empty (scancodes are removed; but interestingly the modifiers remain).
image

@Calinou
Copy link
Member

Calinou commented Mar 6, 2020

I can reproduce this on commit 0c53f1f (specifically after rebinding the freelook keys to be AZERTY-friendly).

@akien-mga
Copy link
Member

Possibly related to #18020, CC @bruvzg.

@bruvzg
Copy link
Member

bruvzg commented Mar 6, 2020

I can't reproduce it with current master, at least with newly assigned shortcuts. But shortcuts assigned before #18020 was merged will be invalid since scancode was renamed to keycode.

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 6, 2020

Uh, I'm constantly switching between pre-Vulkan and master, so this is a problem for me .-.

@akien-mga
Copy link
Member

Pre-Vulkan master branch is almost the same as the 3.2 branch, so I'd advise using that instead if you need a usable version. I don't think it makes much sense to add some compatibility glue for bindings made with 4.0.dev before #18020, as these older revisions will quickly be obsolete.

There's no (direct) concern in the 3.x to 4.0 migration since they use different editor settings files.

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 6, 2020

So this can be closed I guess.
I'm using pre-Vulkan mostly for #35704.

@KoBeWi KoBeWi closed this as completed Mar 6, 2020
@KoBeWi KoBeWi added archived and removed bug labels Mar 6, 2020
@KoBeWi KoBeWi removed this from the 4.0 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants