Array out of bounds in sprite_3d.cpp

[qarmin]

Godot version:
Godot 4.0 master(vulkan)
OS/device including version:
Ubuntu 19.10
Issue description:
Here is created uvs with only 4 elements

godot/scene/3d/sprite_3d.cpp

Line 455 in 1eb424e

Vector2 uvs[4] = {

but here is readed also element 5 and 6

godot/scene/3d/sprite_3d.cpp

Lines 507 to 514 in 1eb424e

	for (int i = 0; i < 6; i++) {
	static const int index[6] = { 0, 1, 2, 0, 2, 3 };
	VS::get_singleton()->immediate_normal(immediate, normal);
	VS::get_singleton()->immediate_tangent(immediate, tangent);
	VS::get_singleton()->immediate_color(immediate, color);
	VS::get_singleton()->immediate_uv(immediate, uvs[i]);

also here is same problem

godot/scene/3d/sprite_3d.cpp

Line 848 in 1eb424e

VS::get_singleton()->immediate_uv(immediate, uvs[i]);

[Calinou]

By the way, Sprite3D needs a refactor to avoid using ImmediateGeometry, which is slow and unnecessary for geometry that doesn't change.

[Calinou]

If you can build Godot from source, please build the 3.2 branch and test this again now that #39867 has been merged. (That pull request also makes Sprite3D much faster to render.)

You can also use this Windows 64-bit editor binary for testing.

[qarmin]

Out of bounds code was added only in Godot 4.0, so there is no need to test it with 3.2.

https://github.com/godotengine/godot/blame/1eb424ec9549bdd086dfb54c847d107519be73d9/scene/3d/sprite_3d.cpp#L507

[qarmin]

Fixed by #44199