-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2. Object disappearing when using the scrollwheel outside of running window Visibility Rect #34713
Comments
OS: Arch Linux, kernel 5.4.6-arch3-1 edit Updated to the latest commit (from 5fa1905) edit 2 After looking at the GIF again, I noticed a sharp frame drop when you dragged your mouse outside the screen. Though my frames don't drop when I do it, the particles do disappear if I forcefully reduce my physics frames to 30 (physics/common/physics_fps). Well, OK they don't disappear, they violently shake on the top left of the screen. |
@FlashDaggerX The frame drop is just due to screen recording. When I don't screen record, then there is absolutely no frame dropping with this minimal project regardless of what I do. |
Seems like particles visibility simply turns off when they go outside screen/viewport, that's an issue I'm experiencing for quite some time, for instance when a projectile with a smoke trail goes outside the screen. I think what is needed is calculating the bounding box of all particles before switching visibility completely, but since it's GPU accelerated not sure how feasible the solution might be. |
@Xrayez If that's the case, why does are the particles then only disappearing when I use the scrollwheel outside of the viewport? |
I couldn't reproduce either in latest build btw, it just may be connected to the issue in some way, not sure how scrollwheel could affect this. 👀 |
With Particles2D, you can enlarge the AABB manually using Drawing > Visibility Rect in the inspector. With CPUParticles2D, the AABB is supposed to be computed automatically since Godot 3.1. |
Thanks, yes it did solve my issue, not sure if this was present back in 2.1 last time I checked! I might have also misinterpreted this property as something which clips the drawing instead so I neglected it in the past... @golddotasksquestions try to increase the visibility rect for the particles and see if this solves anything for some clues. |
@Xrayez You got it! |
Can anyone still reproduce this bug in Godot 3.2.3 or any later release? I can't reproduce either btw |
I can still reproduce it with the minimal project above. (both Godot 3.2.3 stable, 3.2.4 beta3) |
I can't reproduce this with the included MRP on 3.3.2 on Linux. Increasing the Visibility Rect in the Particles node should work around the issue in the meantime (tested by @ev1lbl0w). |
I can still reproduce it with the included MRP on 3.3.2 stable on Win. Increasing the Visibility Rect works as a workaround but does not eliminate the issue. |
@golddotasksquestions Can you (or anyone else) still reproduce this bug in Godot 4.0.beta4 or any later release? You can also check this again in 3.5.1 to make sure. If yes, please ensure that a 4.0 up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop. |
Yes, I can still reproduce this on the same hardware. Also in Godot4 Beta4. I have converted the original MRP to Godot 4 Beta4 and added it to the original post. While testing this again, I noticed not only the particles are disappearing, but the whole KinematicBody2D/CharacterBody2D the Particles2D are added to. So maybe this is not related to the Particles? I checked the above gif I made years ago, and even there it seems like the Sprite is disappearing, indicating the KB/CB is totally disappearing when scrolling outside, not just the Particles. That something I apparently did not notice before. So I made two more small test scenes (one with CharacterBody2D and Sprite2D and one with only the Sprite), and the issue was present in both as long as they where moved to the global_mouse_position()
Godot4 beta4 MRP: |
Godot version: 3.2 beta4
OS/device including version: Win7
Issue description:
![particles_scrollwheel](https://user-images.githubusercontent.com/47016402/71607561-a73cb700-2b7a-11ea-9e9e-a74ee7a79c48.gif)
When using the mouse scrollwheel outside of the running window, particles disappear. Moving the mouse back into the window area causes the particles to reappear. The scrollwheel has no affect if mouse is inside the running window. There is no input map assigned to the mouse scrollwheel. No code using the scrollwheel scancode. The issue is present when running the project from the editor as well as when running the exported project.
Steps to reproduce:
Run the minimal project and scroll inside vs outside the running window. Edit: Scroll beyond the Visibility Rect!
Minimal reproduction project:
particle_test_scrollwheel.zip
Godot4 Beta4 MRP:
scrollwheel_visibility_test.zip
The text was updated successfully, but these errors were encountered: