Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompleting searched signal callback inserts method call #33550

Closed
KoBeWi opened this issue Nov 11, 2019 · 5 comments
Closed

Autocompleting searched signal callback inserts method call #33550

KoBeWi opened this issue Nov 11, 2019 · 5 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 11, 2019

Godot version:
3.2 beta1

Issue description:
wqq8ksn1QT

Works correctly if you just select the method from list, but it means you can't search for method.

@code-xD
Copy link
Contributor

code-xD commented Nov 13, 2019

Could you elaborate on this issue? The gif is not clear to me.

@bojidar-bg
Copy link
Contributor

It should insert "on_sword_hit" (a string containing the function's name) rather than on_sword_hit() (a call to that function). This might or might not be related to the OP not starting autocompletion with " or ', but directly with the function name. Could also be related to #33425.

@code-xD
Copy link
Contributor

code-xD commented Nov 13, 2019

I found similar issues in the issues tab. I guess there is a common fix for all these issues?

@bojidar-bg
Copy link
Contributor

There currently is not a common fix for all the similar issues, mainly because there has been little work on fixing them. There could be a common fix, but it is not as much of a priority as is fixing the issues.

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Jan 22, 2020
@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 18, 2020

Still valid in 3.2.4 beta4
In 4.0 the autocompletion seems broken right now, but the issue is probably gone, because connect takes Callables (i.e. method name without parentheses). Should be fine to close.

@KoBeWi KoBeWi closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants