Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector: clicking on a property value to change it "moves" the value to the left, obstructing productivity flow #28618

Closed
golddotasksquestions opened this issue May 2, 2019 · 1 comment · Fixed by #36231

Comments

@golddotasksquestions
Copy link

golddotasksquestions commented May 2, 2019

Godot version:
3.1 stable

OS/device including version:
Win 7

Issue description:
This is seemingly a minor nuisance, but does hinder the productivity over weeks and months quite a bit:
When clicking on a property value in the inspector, the value shifts left, so even if I clicked in the perfect location to change my property, I have to search again for the right location so click, click again. This is so irritating, that it can lead to a lot more than just twice searching and clicking.
However imho worst of all is that it makes routine movements and musclememory really hard to train and automate.
I was observing myself using various methods to get to the right location of the value string:
using the mouse and LMB click+ LMB click again until I got it right (can take any number of clicks if not 1000% concentrated), LMB click drag + backspace then rewriting deleted characters, LMB click +backspace deleting everything, rewriting everything, LMB click + arrow keys to move to the correct position ...

inspector_value_click

Ideally, the position of the values should not change when clicking on them with the LMB.

Right now, it does not matter where I LMB click on the value, one click always selects the whole value. Imho only double click should do that. Single LMB click should bring the cursor exactly at the string location where you clicked. Single LMB click and hold does the same but if I then drag the cursor left or right I can mark any number of adjacent characters left or right from where I clicked. This is how textboxes usually work.

Currently LMB single click then rewriting everything is the most efficient, because there is no real alternative.
It is however a less efficient solution overall,

  • for one, because by clicking on the value the user already has had the opportunity to select where exactly to insert the cursor, and
  • second because the user has to remove both hands to write fast, so also the hand from the mouse clicking the value location.
  • Rewriting instead of changing only the desired digits or characters bears the risk of reintroducing bugs in already working code.
  • When complete rewriting is actually desired, it is available within a double click or click-drag (Edit: or clicking in the empty area)
  • Single LMB click and drag would also allow complete rewrite without loss of usability.

Edit:

  • GammaGames has suggested to use the empty area next to a value also as "click here to select whole value" which I also think is a great idea!
  • LMB click+drag could be relocated to the property name as it is done in many if not most other professional editing Software.
    inspector_clickdrag
@Calinou
Copy link
Member

Calinou commented Jul 15, 2020

This is now fixed in the master branch thanks to #36231. (The fix applies both to scalar and vector fields.)

Normal property

Editing property

I asked for cherry-picking to the 3.2 branch in #36231.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants