Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC passes Objects by default #27395

Closed
LunaticExperimentalist opened this issue Mar 25, 2019 · 1 comment · Fixed by #27485
Closed

RPC passes Objects by default #27395

LunaticExperimentalist opened this issue Mar 25, 2019 · 1 comment · Fixed by #27485
Assignees
@Faless
Labels
bug confirmed high priority topic:network
Milestone
3.2

Comments

@LunaticExperimentalist
Copy link

Godot version:
3.1

OS/device including version:
Debian 9

Issue description:
High level multiplayer API allows passing Objects with scripts to peers. This opens up a remote code execution exploit.

Steps to reproduce:
Initialize NetworkedMultiplayerENet on a client and server, connect them, and set them as the network peer interfaces for their respective scene trees. Pass scripted object over RPC.

Minimal reproduction project:
Exploit.zip
@Faless Faless self-assigned this Mar 25, 2019
@Faless Faless modified the milestones: 3.1, 3.2 Mar 25, 2019
@Faless
Copy link
Collaborator

Faless commented Mar 25, 2019

This must be a bug down the line. allow_object_decoding is false by default, so the label should not be decoded. I'm investigating.

This was referenced Mar 25, 2019
Closed
Merged
@Faless Faless mentioned this issue May 7, 2019
Closed
@Faless Faless mentioned this issue Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Faless Faless

Labels
bug confirmed high priority topic:network
Projects
None yet
Milestone
3.2
2 participants
@Faless @LunaticExperimentalist