Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimporting files with multiple selection doesn't take Preset change into ccount unless all properties are ticked #26754

Closed
Darkinggq opened this issue Mar 7, 2019 · 8 comments

Comments

@Darkinggq
Copy link

Darkinggq commented Mar 7, 2019

Godot version:
v3.1.rc.custom_build. 6976181

Steps to reproduce:
out

Rare crash:

handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x33060) [0x7fa40ee0a060] (??:0)
[2] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x1dac826] (/home/xxx/2/godot/./core/object.h:567)
[3] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x1dac9fb] (/home/xxx/2/godot/./core/cowdata.h:369)
[4] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0xde59c4] (/home/xxx/2/godot/./core/cowdata.h:369)
[5] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0xe054b2] (/home/xxx/2/godot/./core/cowdata.h:369)
[6] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23c2303] (/home/xxx/2/godot/core/object.cpp:942 (discriminator 1))
[7] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23cdddb] (/home/xxx/2/godot/./core/variant.h:421)
[8] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23ceca0] (/home/xxx/2/godot/core/object.cpp:1285)
[9] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0xd75779] (/home/xxx/2/godot/editor/editor_file_system.cpp:1782 (discriminator 4))
[10] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0xeee472] (/home/xxx/2/godot/editor/import_dock.cpp:462)
[11] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0xeeeb21] (/home/xxx/2/godot/editor/import_dock.cpp:422)
[12] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x4e4f2c] (/home/xxx/2/godot/./core/method_bind.gen.inc:57 (discriminator 4))
[13] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23c2303] (/home/xxx/2/godot/core/object.cpp:942 (discriminator 1))
[14] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23cdddb] (/home/xxx/2/godot/./core/variant.h:421)
[15] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23ceca0] (/home/xxx/2/godot/core/object.cpp:1285)
[16] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x1626a55] (/home/xxx/2/godot/scene/gui/base_button.cpp:139 (discriminator 2))
[17] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0xeec0c2] (/home/xxx/2/godot/./core/reference.h:267)
[18] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23c3080] (/home/xxx/2/godot/./core/variant.h:421)
[19] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23c0bd1] (/home/xxx/2/godot/core/object.cpp:883)
[20] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x160bf51] (/home/xxx/2/godot/./core/variant.h:421)
[21] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x160fb09] (/home/xxx/2/godot/./core/reference.h:285)
[22] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x1611bfc] (/home/xxx/2/godot/./core/reference.h:285)
[23] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x1611d7e] (/home/xxx/2/godot/./core/reference.h:285)
[24] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x6cb7a4] (/home/xxx/2/godot/./core/reference.h:285)
[25] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23c2303] (/home/xxx/2/godot/core/object.cpp:942 (discriminator 1))
[26] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x23c0b65] (/home/xxx/2/godot/core/object.cpp:868)
[27] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x15e1e3e] (/home/xxx/2/godot/./core/variant.h:421)
[28] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x15e4fc0] (/home/xxx/2/godot/scene/main/scene_tree.cpp:418 (discriminator 6))
[29] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x45d4a1] (/home/xxx/2/godot/./core/reference.h:285)
[30] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x45a7d2] (/home/xxx/2/godot/./core/list.h:291)
[31] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x44e934] (/home/xxx/2/godot/platform/x11/os_x11.cpp:2462)
[32] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x450c40] (/home/xxx/2/godot/platform/x11/os_x11.cpp:3004)
[33] /home/xxx/2/godot/bin/godot.x11.opt.tools.64(main+0xc1) [0x442ba1] (/home/xxx/2/godot/platform/x11/godot_x11.cpp:55)
[34] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fa40edf72e1] (??:0)
[35] /home/xxx/2/godot/bin/godot.x11.opt.tools.64() [0x444c6a] (??:?)
-- END OF BACKTRACE --

@mrcdk
Copy link
Contributor

mrcdk commented Mar 7, 2019

You need to select which properties to update before reimporting them.

@Darkinggq
Copy link
Author

I need a click Import files fast

@akien-mga
Copy link
Member

You need to select which properties to update before reimporting them.

That makes sense, but I actually ran into the exact same issue today and wasted quite some time reimporting 500 textures to see that nothing had changed.

IMO when we do multi select + pick a whole new preset, it should be able to all properties (that's the point of the presets).

@akien-mga akien-mga changed the title Import files .png bug Reimporting files with multiple selection doesn't take Preset change into ccount unless all properties are ticked Mar 7, 2019
@akien-mga
Copy link
Member

The crash is likely another variant of #26749.

@rafael-abuawad
Copy link

Select all the files you want, then check or uncheck the properties manually, that way is working for me

@arctic-carbide
Copy link

arctic-carbide commented Apr 30, 2019

Select all the files you want, then check or uncheck the properties manually, that way is working for me

I can confirm this works as a workaround at this time. Basically, you select all your files you want to reimport, select your preset and take note of what changed, and then toggle the properties that changed to apply it to all selected files. After that, reimporting will commit those changes to all selected files.

@chucklepie
Copy link

Is this going to get fixed, as I wasted a lot of time myself, like others, not realising the importer had siliently ignored everything I've done in the editor...

@KoBeWi
Copy link
Member

KoBeWi commented Aug 22, 2020

Fixed in 3.2.
image
The checkboxex to the left appear when multiple resources are selected and when checked they change settings of multiple resources.

@KoBeWi KoBeWi closed this as completed Aug 22, 2020
@KoBeWi KoBeWi added this to the 3.2 milestone Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants