Polygon2D texture not displaying correctly.

[ghost]

Godot version:

9c17688

OS/device including version:

Win10 64bit

Issue description:

When using a atlas/region texture resource for the polygon texture, it works fine in the polygon editor, but shows the whole source texture in the canvas editor and in game.

From this:

To this:

Steps to reproduce:

1. Create an atlas texture resource.
2. Assign it to a Polygon2D's texture.
3. Create the points of the polygon.

Minimal reproduction project:

3.1 Polygon Texture Issue.zip

[reduz]

They are not really meant to work together. AtlasTexture only really works for sprites and UI, not meshes or polygon.

It could probably hacked in Polygon by detecting its an atlas and ajusting the UVs I guess...

[ghost]

Oh, wondering why the UV/Poly editor handles it. Thanks. It would be very useful if it works out.

The new 2D mesh invites texture parts over sprite sheets, and we use Texture Packer to try to make very tightly packed atlas textures.

I'm not sure of the backend rendering performance, but I'm only assuming that it would still be an issue to load thousands of little textures rather than a few dozen larger ones. We'd really like to make use of mesh warping on these atlas parts to solve very difficult and time consuming blending issues on our characters.

[reduz]

In any case, not urgent for 3.1

[reduz]

@avencherus you can now draw on a single image and then use the polygon drawn tool from the UV editor to make your character, no need for atlas

[ghost]

@reduz Thanks, had a blind spot there, hadn't actually considered that. XD I think since most the textures are intended to be assigned to Sprites. Should be able to re-organize parts into their own texture for polygons and maybe write an import tool.

[akien-mga]

Still reproducible in the current master branch.

[jonbonazza]

Radial TextureProgress still shows whole Atlas Texture instead of selected region, but only on values 100 > x > 0. if value is 100 or 0, it works fine.

[ghost]

Cannot think of a work around for when using Polygon2D as a seamless looping texture, other than not use an atlas for certain textures.

[KoBeWi]

Still valid in 3.2.4 beta4

[mdarius31]

Still valid in 3.4.4

[Calinou]

Related to #34837.

[aXu-AP]

Should this be solved by adding support for AtlasTexture in CanvasItem.draw_polygon (or in RendererCanvasCull)? Code from #66352 could be moved into that class, enabling the fix on larger scale. Needs to check if there's other places where this was supported explicitly.

Other solution is to modify the editor to show the whole texture instead of the AtlasTexture part of it. Ie. what you
see is what you get, and polygons don't support AtlasTexture.

[arkology]

Should this be solved by adding support for AtlasTexture in CanvasItem.draw_polygon (or in RendererCanvasCull)? Code from #66352 could be moved into that class, enabling the fix on larger scale.

As I see this is done in #91724 but issue is still there,

[aXu-AP]

I see, I was wrong. Polygon2D constructs a mesh internally and draws it.

godot/scene/2d/polygon_2d.cpp

Line 398 in 0c45ace

RS::get_singleton()->canvas_item_add_mesh(get_canvas_item(), mesh, Transform2D(), Color(1, 1, 1), texture.is_valid() ? texture->get_rid() : RID());

I think this is needed for multiple polygons and bone support, but it means that the support has to be explicit 👀

[arkology]

I think we could add uv remapping to CanvasItem::draw_mesh same way as it is done for CanvasItem::draw_polygon several lines of code above. This will be most universal and simple (in terms of code readability) way to implement it.
BUT it will be necessary to create a copy of entry mesh to keep original mesh unchanged.
So there's question. Is it OK to create a copy of mesh inside CanvasItem::draw_mesh?
Maybe someone from "mature" contributors could say is it a way to go)
Nevermind, I take a look at mesh creation function and it is as easy as engineering spaceship😄