Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going back in the Inspector while editing a GridMap node makes it and the previous node selected #21297

Open
YeldhamDev opened this issue Aug 23, 2018 · 10 comments

Comments

@YeldhamDev
Copy link
Member

Godot version:
2db4942

Issue description:
Basically this:
screenshot at 2018-08-22 21-46-22

@vazzup
Copy link

vazzup commented Aug 23, 2018

Hi, I'd like to help. Could you specify steps to recreate the bug?

@YeldhamDev
Copy link
Member Author

@vazzup Basically what's said in the title, select a GridMap node, go back in the inspector, using these:
screenshot at 2018-08-23 11-27-26

And both the GridMap and the previous node will be selected.

@vazzup
Copy link

vazzup commented Aug 23, 2018

Ok, thanks. Will look into it

@BornStellarMakesEternalLasting

I can confirm this happens in 3.0.2 and 3.0.6. The inspector arrows don't seem to disselect what is in the history. I've also seen that this works with more nodes than just the gridmap node.

@vazzup
Copy link

vazzup commented Aug 24, 2018

Yes, it is also a bug in the master branch. Also, if there are multiple previous nodes, all of them get selected.

@vazzup
Copy link

vazzup commented Aug 24, 2018

I'm looking at the editor_node.cpp file and I think the change will be around line no. 1476 in the _edit_current function.

@vazzup
Copy link

vazzup commented Aug 27, 2018

Hi, after digging deep, I'm a bit stuck with this bug. I think the bug may be from the EditorInspector::update_tree function, but I can't say for sure. Can someone else please point me in the right direction?

@avril-gh
Copy link
Contributor

I've also seen that this works with more nodes than just the gridmap node.

theres also strange behavior while debugging remote tree (which is running on android device),
When one select a node (in debugger) , other nodes will select itself randomly, and theres no way to stop it, thus no way to use this feature to debug / change properties in inspector at runtime, ect.
Its not easy to reproduce it on simple project with fiew nodes created in editor,
but it begin to appear in projects with higher count of nodes created at runtime.

Just mentioning it here, since it sounds similar, ...but perhaps i should make a new issue for this.

@DeuxAlpha
Copy link

DeuxAlpha commented Sep 14, 2018

Hi! I'm able to reproduce the bug, but it doesn't seem to be related to GridMaps only. In my case, any node will cause this issue. It doesn't seem to influence functionality, however, since the inspector displays the correct Node and its properties. The only issue is that several nodes look highlighted. Additionally, the further you go back in history, the more Nodes get highlighted (once again, not influencing functionality, but aesthetics only).

EDIT:
Another thing I just noticed was that the bug only seems to occur on Spatial Nodes, but not on any other type of Node. For example, if I traverse the history between spatial nodes, the bug appears, but if I move to another type of node, the bug does not occur and/or fixes itself (i.e. only the actually selected Node is highlighted). If I move to a spatial Node from a different kind of node, both the different one and the spatial Node stay selected (and any other spatial Nodes the further backwards I go).

FYI, the behavior stays the same no matter whether I move forward or backward in history.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 18, 2020

Still valid in 4e0f31a
As mentioned above, this applies not only to GridMap, but also mixed-type nodes, e.g. when you select Node2D then Spatial, then go back and then forward (going back doesn't seem to trigger it), both get selected. Might be somehow related to #36291

@YeldhamDev YeldhamDev added this to the 4.0 milestone Jul 30, 2022
@KoBeWi KoBeWi removed this from the 4.0 milestone Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants