Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening project in the Project Manager when run in standalone terminal closes Godot (parent process killed) #18304

Closed
ignaloidas opened this issue Apr 19, 2018 · 13 comments

Comments

@ignaloidas
Copy link

ignaloidas commented Apr 19, 2018

Godot version:
3.0.2

OS/device including version:
Kubuntu 17.10 AMD R5 M430 GPU and Intel iGPU

Issue description:
When Godot is launched by a console only running Godot (no bash, etc.) when trying to open a project in editor, it crashes

Steps to reproduce:
If using KDE based system, launch Godot with this command:
konsole -e /path/to/godot
then when you try open a project in a editor, it crashes
EDIT:just tested, also works with terminator

Minimal reproduction project:
Tested with official 3D platformer demo

@LinuxUserGD
Copy link
Contributor

LinuxUserGD commented Apr 19, 2018

What about xterm (running xterm -e path/to/godot)? 3.0.2 standard or mono?

@ignaloidas
Copy link
Author

What about xterm (running xterm -e path/to/godot)?

Just tested, also crashes, looks like this happens for all terminal emulators

@Calinou
Copy link
Member

Calinou commented Apr 19, 2018

I can reproduce this issue on commit df79cc8 using Fedora 27 and KDE Plasma 5.12.4, by launching Godot using konsole -e godot (Godot is available in the PATH on this system).

The project manager will open, but it will crash when attempting to edit a project. However, running the project (instead of editing it) won't crash Godot.

@akien-mga
Copy link
Member

It does not crash and it's not a bug: when you open a project in the project manager, Godot spawns a new process. If you ran the initial project manager project in a standalone terminal, it gets killed when the project manager process is killed, and thus kills the child processes.

@ignaloidas
Copy link
Author

it gets killed when the project manager process is killed, and thus kills the child processes.

Oh makes sense, any way to circumvent this and have the terminal always alive?

@LinuxUserGD
Copy link
Contributor

LinuxUserGD commented Apr 20, 2018

It keeps alive on Antergos using Godot Mono and gnome-terminal, don't know why. Seems like the terminal process is finished instead of killed so the terminal doesn't receive errors from the Godot Editor. If I close the terminal I have to manually close the editor.

@NuclearPhoenixx
Copy link

Oh makes sense, any way to circumvent this and have the terminal always alive?

Just open the terminal yourself and then execute Godot like any other normal program? What are you trying to do? 🤔

@ignaloidas
Copy link
Author

I'm trying to make a desktop launch script with console, and I can't see a way, though I'm not a very experienced Linux user

@NuclearPhoenixx
Copy link

NuclearPhoenixx commented Apr 24, 2018

Ah I see, try making a starter with /path/to/godot_binary only that works for me. If you got it installed you can just do /usr/bin/godot or godot, hope this helps :)

@akien-mga akien-mga changed the title Opening Godot with standalone terminal crashes editor. Opening project in the Project Manager when run in standalone terminal closes Godot (parent process killed) May 1, 2018
@akien-mga
Copy link
Member

Just for the cross-reference, different issue but similar cause (process forking when opening a project): #18233

@akien-mga
Copy link
Member

This seems no longer reproducible for me with Godot 3.2.2 on Mageia, running konsole -e godot. The spawned terminal gets closed when editing a project in the project manager, but the newly spawned instance doesn't get killed.
Can anyone still reproduce it?

@ignaloidas
Copy link
Author

This seems no longer reproducible for me with Godot 3.2.2 on Mageia, running konsole -e godot. The spawned terminal gets closed when editing a project in the project manager, but the newly spawned instance doesn't get killed.
Can anyone still reproduce it?

Same behavior here, tested with konsole and gnome-terminal. Seems OK to close this now.

@akien-mga
Copy link
Member

Thanks, closing.

@akien-mga akien-mga added this to the 3.2 milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants