GDScript enums override constants.

[ghost]

I'm using Windows version of 2.1.

The problem I ran into is that enums using the same names as constants will replace their value.

Such as:

const NUMBER = 100

enum INT { NUMBER = 2 }

func _ready():
	print(NUMBER) # Shows 2

[akien-mga]

I haven't tested but it's likely the same in master too, so should be fixed for both. cc @bojidar-bg

[neikeq]

AFAIK, this is expected. It's similar to C++ enums. It should error because NUMBER is already declared though.

[akien-mga]

Yeah, I tagged "bug" because it's a bug that it allows this shadowing instead of erroring out.

[vnen]

Related to #6221.

[Sslaxx]

Per #6221 (comment) @reduz intends (intended?) to leave this issue for 3.1.

[bojidar-bg]

I think we should add some way to mark enums as "to-be-kept-as-dictionary-only". Some examples to explain it:

enum {INT = 1, STRING}
# equivalent to:
const INT = 1; const STRING = 2

# ---

enum Type {INT = 1, STRING}
# equivalent to:
const INT = 1; const STRING = 2
const Type = {INT = 1, STRING = 2}

# ---

!enum Type {INT = 1, STRING} # some cool proposal here
# equivalent to:
const Type = {INT = 1, STRING = 2}

Now, the question is how to mark those enums, feel free to propose the syntax 😃 .

[akien-mga]

No, we don't need to add support for half shadowing. Just trigger a syntax error when an enum shadows a constant.

[vnen]

@bojidar-bg I don't get the point, if you need just a dictionary you can simply make one. There's no much gain in avoiding to set the values manually.

[reduz]

@bojidar-bg guess popular demand here just wants an error to be triggered :)

[akien-mga]

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

[reduz]

@vnen , @bojidar-bg what to do with this?