Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichTextLabel's bbcode_text property is not tag-stack-aware. #12882

Open
Tracked by #39144
willnationsdev opened this issue Nov 13, 2017 · 1 comment
Open
Tracked by #39144

RichTextLabel's bbcode_text property is not tag-stack-aware. #12882

willnationsdev opened this issue Nov 13, 2017 · 1 comment

Comments

@willnationsdev
Copy link
Contributor

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10
Godot master

Issue description:
If you manually add content to RichTextLabel's internal tag stack using append_bbcode and the push_*/pop functions, I would expect to be able to print bbcode_text and see the corresponding opening and closing tags visible in the output (at least, as much as is possible. I know you can't perfectly do that with push_meta(Variant), but for most you could). To the end user, they don't even see the internal tag stack, so when they use append_bbcode, they THINK that they are in fact editing bbcode_text...except that they aren't...<_< We should try to maintain that illusion.

Steps to reproduce:
Start a new scene with RichTextLabel as the root. Toggle on the bbcode bool. Add a script:

# RichTextLabel.gd
func _ready():
    add_text("hello")
    print(bbcode_text) # prints nothing to the screen

I would have expected to see "hello" printed as a result of this.

Also, fixing this Issue would probably also fix #12881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants