Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting text horizontally in TextEdit works strangely #103401

Closed
JekSun97 opened this issue Feb 28, 2025 · 3 comments · Fixed by #103410
Closed

Selecting text horizontally in TextEdit works strangely #103401

JekSun97 opened this issue Feb 28, 2025 · 3 comments · Fixed by #103410

Comments

@JekSun97
Copy link
Contributor

Tested versions

Godot 4.4 RC2

System information

Godot v4.4.rc2 - Windows 10 (build 19045) - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated Radeon RX 560 Series (Advanced Micro Devices, Inc.; 31.0.21912.14) - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 threads)

Issue description

I encountered one inconvenience in the shader editor, when we select a line from its end to its beginning, and if we want to select a smaller section of text (moving the cursor towards the beginning of the selection), it will be very difficult, since the ScrollContainer will constantly move in the direction of the mouse movement.

It is not easy to explain, so I will attach a video of the problem:

0228.mp4

In this video I try to highlight the code
ALBEDO = vec3(texture(skin_texture, UV).r,texture(skin_texture, UV).g,texture(skin_texture, UV).b) * final_color;
but only this part - vec3(texture(skin_texture, UV).r,texture(skin_texture, UV).g,texture(skin_texture, UV).b) * final_color;. It's not easy to do this - the code editor instantly moves to the right.

Steps to reproduce

  1. Write a long code in the shader editor or in the script editor.
  2. Select the part of the code you need, starting from the end of the line.
  3. The text editor scrolls instantly, which is why we do not have time to select the code to the part we need.

Minimal reproduction project (MRP)

N/A

@JekSun97
Copy link
Contributor Author

JekSun97 commented Feb 28, 2025

This is most likely a regression that appeared in 4.4 beta2, it does not happen in beta1.

4.4 beta1:

0228.1.mp4

@AThousandShips
Copy link
Member

Can confirm the regression, will bisect

@AThousandShips AThousandShips moved this from Unassessed to Bad in 4.x Release Blockers Feb 28, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Feb 28, 2025
@AThousandShips
Copy link
Member

Bisected to:

CC @kitbdev @KoBeWi

This was done to solve:

So unintended consequence but if I am to guess this is because the way selection works relies on the broken behavior fixed by this and should be adjusted to not center in this way in these cases, but don't know the relevant code well enough to propose any fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

2 participants