Display correct symbol in warning when unique name is used without @onready annotation #102389
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
reviewed
Feb 4, 2025
| GDScriptParser::GetNodeNode *get_node_node = static_cast<GDScriptParser::GetNodeNode *>(expr); | ||
| String offending_syntax = "get_node()"; | ||
| if (is_using_shorthand) { | ||
| if (get_node_node->full_path.begins_with("%")) { |
There was a problem hiding this comment.
There is use_dollar property:
godot/modules/gdscript/gdscript_parser.h
Line 877 in eee39f0
Compare: %Node and $"%Node". Also please add a test.
| @@ -1093,7 +1093,16 @@ void GDScriptAnalyzer::resolve_class_member(GDScriptParser::ClassNode *p_class, | |||
| } | |||
| } | |||
| if (is_get_node) { | |||
| parser->push_warning(member.variable, GDScriptWarning::GET_NODE_DEFAULT_WITHOUT_ONREADY, is_using_shorthand ? "$" : "get_node()"); | |||
| GDScriptParser::GetNodeNode *get_node_node = static_cast<GDScriptParser::GetNodeNode *>(expr); | |||
There was a problem hiding this comment.
I'd move this into the if (is_using_shorthand) condition. Otherwise it's an incorrect cast if the type is not GET_NODE.
| parser->push_warning(member.variable, GDScriptWarning::GET_NODE_DEFAULT_WITHOUT_ONREADY, is_using_shorthand ? "$" : "get_node()"); | ||
| GDScriptParser::GetNodeNode *get_node_node = static_cast<GDScriptParser::GetNodeNode *>(expr); | ||
| String offending_syntax = "get_node()"; | ||
| if (is_using_shorthand) { |
There was a problem hiding this comment.
There are 2 variables: is_get_node and is_using_shorthand. Are you sure that this is the correct one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102386.
This adds a few lines of code to the procedure generating the warning. It simply checks if the path being used in shorthand begins with "%", and if so uses that symbol instead of "$" for the warning.
Godot.4.4.Fixed.Error.Message.about.Unique.Name.Nodes.mp4