From de7ce9a85f3b8d7776fcca437f17136474584936 Mon Sep 17 00:00:00 2001 From: Hendrik Brucker Date: Fri, 2 Aug 2024 13:26:49 +0200 Subject: [PATCH] Reduce size changes of visual shader nodes when connecting/disconnecting - plus small internal rename --- editor/plugins/visual_shader_editor_plugin.cpp | 12 ++++++------ editor/themes/editor_theme_manager.cpp | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/editor/plugins/visual_shader_editor_plugin.cpp b/editor/plugins/visual_shader_editor_plugin.cpp index 351adc569cdd..2da9d66d9a43 100644 --- a/editor/plugins/visual_shader_editor_plugin.cpp +++ b/editor/plugins/visual_shader_editor_plugin.cpp @@ -1096,14 +1096,14 @@ void VisualShaderGraphPlugin::add_node(VisualShader::Type p_type, int p_id, bool default_value = vsnode->get_input_port_default_value(j); } - Button *button = memnew(Button); - hb->add_child(button); - register_default_input_button(p_id, j, button); - button->connect(SceneStringName(pressed), callable_mp(editor, &VisualShaderEditor::_edit_port_default_input).bind(button, p_id, j)); + Button *default_input_btn = memnew(Button); + hb->add_child(default_input_btn); + register_default_input_button(p_id, j, default_input_btn); + default_input_btn->connect(SceneStringName(pressed), callable_mp(editor, &VisualShaderEditor::_edit_port_default_input).bind(default_input_btn, p_id, j)); if (default_value.get_type() != Variant::NIL) { // only a label set_input_port_default_value(p_type, p_id, j, default_value); } else { - button->hide(); + default_input_btn->hide(); } if (j == 0 && custom_editor) { @@ -1144,7 +1144,7 @@ void VisualShaderGraphPlugin::add_node(VisualShader::Type p_type, int p_id, bool Label *label = memnew(Label); label->set_auto_translate_mode(Node::AUTO_TRANSLATE_MODE_DISABLED); // TODO: Implement proper translation switch. label->set_text(name_left); - label->add_theme_style_override(CoreStringName(normal), editor->get_theme_stylebox(SNAME("label_style"), SNAME("VShaderEditor"))); //more compact + label->add_theme_style_override(CoreStringName(normal), editor->get_theme_stylebox(SNAME("label_style"), SNAME("VShaderEditor"))); hb->add_child(label); if (vsnode->is_input_port_default(j, mode) && !port_left_used) { diff --git a/editor/themes/editor_theme_manager.cpp b/editor/themes/editor_theme_manager.cpp index a63b6d4e140a..9d8cbb053d8f 100644 --- a/editor/themes/editor_theme_manager.cpp +++ b/editor/themes/editor_theme_manager.cpp @@ -2346,7 +2346,7 @@ void EditorThemeManager::_populate_editor_styles(const Ref &p_theme } // VisualShader editor. - p_theme->set_stylebox("label_style", "VShaderEditor", make_empty_stylebox(2, 1, 2, 1)); + p_theme->set_stylebox("label_style", "VShaderEditor", make_empty_stylebox(4, 6, 4, 6)); // StateMachine graph. {