From 83333f7e158830a189cc085abf7ad0451154d640 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Fri, 24 Dec 2021 01:10:13 +0000 Subject: [PATCH] drivers/vulkan: limit pEngineName to only the engine name, without its version It's supposed to be something stable that can be used to identify the engine (using an equality check), so having the version number in there defeats the purpose. While at it, there is no need to prefix it with a second `"GodotEngine"`, nor to copy the static C string into a C++ string to then extract a C string from it :) --- drivers/vulkan/vulkan_context.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/vulkan/vulkan_context.cpp b/drivers/vulkan/vulkan_context.cpp index 24f8ac29b386..aed01b18c9a2 100644 --- a/drivers/vulkan/vulkan_context.cpp +++ b/drivers/vulkan/vulkan_context.cpp @@ -628,14 +628,12 @@ Error VulkanContext::_create_physical_device() { } CharString cs = ProjectSettings::get_singleton()->get("application/config/name").operator String().utf8(); - String name = "GodotEngine " + String(VERSION_FULL_NAME); - CharString namecs = name.utf8(); const VkApplicationInfo app = { /*sType*/ VK_STRUCTURE_TYPE_APPLICATION_INFO, /*pNext*/ nullptr, /*pApplicationName*/ cs.get_data(), /*applicationVersion*/ 0, - /*pEngineName*/ namecs.get_data(), + /*pEngineName*/ VERSION_NAME, /*engineVersion*/ VK_MAKE_VERSION(VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH), /*apiVersion*/ VK_MAKE_VERSION(vulkan_major, vulkan_minor, 0) };