Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid void return in BitField #1407

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix invalid void return in BitField #1407

merged 1 commit into from
Mar 11, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug This has been identified as a bug cherrypick:4.1 cherrypick:4.2 labels Mar 8, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 8, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner March 8, 2024 12:33
Malcolmnixon
Malcolmnixon approved these changes Mar 9, 2024
View reviewed changes
Copy link

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and aligns with the equivalent code in Godot (core/variant/type_info.h).

dsnopek
dsnopek approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me!

@dsnopek dsnopek merged commit efb46f7 into godotengine:master Mar 11, 2024
12 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Mar 11, 2024

Cherry-picked for 4.2 in PR #1410

@AThousandShips AThousandShips deleted the flag_fix branch March 11, 2024 17:59
@dsnopek
Copy link
Collaborator

dsnopek commented Mar 11, 2024

Cherry-picked for 4.1 in PR #1411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

BitField::clear_flag() doesn't compile
3 participants
@AThousandShips @dsnopek @Malcolmnixon