-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with basic pre-requisites #1354
Conversation
Thanks for your contribution! Instead of an ad hoc suggestion in the readme, it's worth it to link to the Godot buildsystem documentation that already explains how to install scons on each supported platform: https://docs.godotengine.org/en/stable/contributing/development/compiling/index.html |
Thanks, I wasn't aware of this (I'm not a C/C++ developer). I also wasn't aware that godot-cpp has the same build requirements as the editor. I'll update my PR momentarily. |
I'm not sure it has exactly the same requirements, but as far as installing scons, engine's docs are already very comprehensive and should be more suitable than a short mention like your original edit was. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In my experience, the pre-requisites are basically the same. So, I think this note makes sense!
Thank you! I hope this will make it easier for more non-C++ developers (like me) to get into building GDExtensions! |
Thanks! And congrats for your first merged godot-cpp contribution 🎉 |
Cherry-picking to 4.2 in #1372 |
Cherry-picking to 4.1 in #1373 |
No description provided.