-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "godot" namespace when binding global constants. #1351
Remove "godot" namespace when binding global constants. #1351
Conversation
Thanks! Is this fixing a problem? Or, just removing the EDIT: Even though it might not be necessary, I think this change would have some knock on effects. The name that's passed to the macro ends up getting passed to |
This is the reason why I make this pr. Currently, if a bind a method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks, that makes sense!
It's always a good idea to include information about the motivation behind a PR. It's very helpful for reviewers :-)
Thanks! |
Cherry-picking to 4.2 in #1372 |
Cherry-picking to 4.1 in #1373 |
Fix redundant prefix "godot." when binding method with godot's global constants.