Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatched paths for binaries & within .gdextension file #50

Closed
Lcbx opened this issue Sep 25, 2024 · 0 comments · Fixed by #44
Closed

mismatched paths for binaries & within .gdextension file #50

Lcbx opened this issue Sep 25, 2024 · 0 comments · Fixed by #44
Labels
bug Something isn't working

Comments

@Lcbx
Copy link

Lcbx commented Sep 25, 2024

Godot version

any

godot-cpp version

any

System information

any

Issue description

supersedes #38

the lib generated has this path/name :
bin/{platform}/{full_libname}

it is then copied to demo as :
demo/bin/{platform}/lib{full_libname}
⭢ notice the extra 'lib' suffix compared to the original lib.

meanwhile the .gdextension file expects :
demo/bin/lib{full_libname}
⭢ notice the missing {platform} directory in path.

These inconsistencies make the demo nonfunctional as-is.
PR #44 is the minimal change to fix this, though it would be convenient if all paths matched.

relevant code :
line 79, 85, 91 of SConstruct file
demo's .gdextension file

@Lcbx Lcbx changed the title mismatched paths in binaries & .gdextension file mismatched paths for binaries & within .gdextension file Sep 25, 2024
@paddy-exe paddy-exe added the bug Something isn't working label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants