Implement FromStr for NodePath #201
Conversation
|
Nothing generally against it, but what is your motivating use case, which isn't already satisfied by |
It's more clear/explicit since |
|
It needs bors try |
tryBuild succeeded: |
godot-core/src/builtin/node_path.rs
Outdated
| type Err = (); | ||
|
|
||
| fn from_str(path: &str) -> Result<Self, ()> { | ||
| Ok(Self::from(&GodotString::from(path))) |
There was a problem hiding this comment.
Can you call Self::from(path) directly?
There is a From<&str> that we can reuse 🙂
juliohq
force-pushed
the
node-path-from-str
branch
from
86f09f5 to
88c7c64
Compare
godot-core/src/builtin/node_path.rs
Outdated
| @@ -60,6 +61,15 @@ impl From<&str> for NodePath { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Check if it's required to implement Err | |||
| impl FromStr for NodePath { | |||
| type Err = (); | |||
There was a problem hiding this comment.
Sorry, something else -- this should probably be Infallible, no? () means there is a value for errors, however we want to have no value as it always succeeds.
This is also what String::from_str does.
You can then remove the TODO.
There was a problem hiding this comment.
Sure, that makes sense to use Infallible there too.
juliohq
force-pushed
the
node-path-from-str
branch
from
88c7c64 to
0556d52
Compare
|
Thanks a lot! bors r+ |
|
Build succeeded: |
Implements
FromStrforNodePath.