Fix broken dialog choices. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StraToN
force-pushed
the
fix-86-dialogs-broken
branch
from
50a079a to
1b0bec2
Compare
|
Great job, @StraToN! 😄I just cherry picked this commit into my Daïza branch and tested, and it works like a charm. I can also confirm that the |
fleskesvor
suggested changes
Mar 26, 2018
device/demo/ui/dd_default.tscn
Outdated
| custom_constants/separation = 10 | ||
| alignment = 0 | ||
| _sections_unfolded = [ "Size Flags" ] |
There was a problem hiding this comment.
I think that maybe we should make a habit of closing sections before staging scene files for commits, and maybe add this to the contributing guidelines as well, since it adds noise to the diff. Not really a problem in this case though, since there are already the other diffs, like the node indices that Godot 3.0 insists on adding.
device/demo/ui/dd_default.tscn
Outdated
| @@ -198,6 +206,7 @@ toggle_mode = false | |||
| enabled_focus_mode = 2 | |||
| shortcut = null | |||
| group = null | |||
| _sections_unfolded = [ "Anchor" ] | |||
There was a problem hiding this comment.
This one should be collapsed too.
device/demo/ui/dd_default.tscn
Outdated
| autowrap = true | ||
| percent_visible = 1.0 | ||
| lines_skipped = 0 | ||
| max_lines_visible = -1 | ||
| _sections_unfolded = [ "Mouse", "Rect", "custom_colors", "custom_fonts" ] |
StraToN
force-pushed
the
fix-86-dialogs-broken
branch
from
1b0bec2 to
bede12e
Compare
StraToN
force-pushed
the
fix-86-dialogs-broken
branch
2 times, most recently
from
9464383 to
6b5c647
Compare
|
@fleskesvor All your remarks were fixed :) |
fleskesvor
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.