feat: Save objects states in Obj Manager to keep them btwn rooms

[StraToN]

Fixes godot-escoria/escoria-issues#193

Unblocks #532

[BHSDuncan]

How are we going to merge this? If we put it into develop before we merge the "instant transition" PR, it's going to cause merge conflicts, especially given how very much different the object and room managers have become.

How do we want to handle this?

[dploeger]

Thanks! 🎁

[dploeger]

Sorry, didn't read your comment, @BHSDuncan. Maybe you could incorporate this change in your branch then? It isn't quite big.

[StraToN]

@BHSDuncan Agree with @dploeger . I'm fine if you cherry-pick this commit into #515 and we close this one.

[StraToN]

Status: waiting for #515 to be merged. Will have to be rebased after that.

[StraToN]

To test:

• checkout branch "room6" from @balloonpopper
• rebase this branch on origin/develop
• If you want to see the issue, test (apply scenario below)
• apply this PR onto the resulting branch
• run

Scenario:

1. Access room06 -> notice that right door is closed
2. exit room06 to room05
3. Get back to room06
   -> if PR not applied, notice that right door is now open
   -> else, notice that right door is still closed

[balloonpopper]

The state was preserved in my testing - the door stays "closed" with the fix applied.
Other issues were found in the transition between these rooms (as dicsussed in the channel) but they seem unrelated to this PR.

[BHSDuncan]

The state was preserved in my testing - the door stays "closed" with the fix applied. Other issues were found in the transition between these rooms (as dicsussed in the channel) but they seem unrelated to this PR.

Can you also maybe check if it's preserved across saving and loading? It should be based on what I see, but best to test. :)

[balloonpopper]

Can you also maybe check if it's preserved across saving and loading? It should be based on what I see, but best to test. :)

FYI : I was asked to hold off on save testing while @StraToN does some more work on the save system.

Code has changed importantly with last commit