Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated exit documentation #545

Merged
merged 5 commits into from
Mar 21, 2022

Conversation

balloonpopper
Copy link
Collaborator

Clarifying when to use ESCexit instead of ESCitem.

@balloonpopper balloonpopper force-pushed the escexit_doco branch 3 times, most recently from e94db46 to 6e325d4 Compare March 18, 2022 05:05
Copy link
Collaborator

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Some small remarks.

addons/escoria-core/game/core-scripts/esc_exit.gd Outdated Show resolved Hide resolved
addons/escoria-core/game/core-scripts/esc_item.gd Outdated Show resolved Hide resolved
@balloonpopper
Copy link
Collaborator Author

Updated @dploeger

Copy link
Collaborator

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thanks. 🎁

addons/escoria-core/game/core-scripts/esc_exit.gd Outdated Show resolved Hide resolved
addons/escoria-core/game/core-scripts/esc_exit.gd Outdated Show resolved Hide resolved
addons/escoria-core/game/core-scripts/esc_item.gd Outdated Show resolved Hide resolved
addons/escoria-core/game/core-scripts/esc_item.gd Outdated Show resolved Hide resolved
@StraToN StraToN merged commit 23ce44e into godot-escoria:develop Mar 21, 2022
@balloonpopper balloonpopper deleted the escexit_doco branch March 24, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants