-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated exit documentation #545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloonpopper
requested review from
StraToN,
BHSDuncan and
dploeger
as code owners
March 18, 2022 03:37
balloonpopper
force-pushed
the
escexit_doco
branch
3 times, most recently
from
March 18, 2022 05:05
e94db46
to
6e325d4
Compare
balloonpopper
force-pushed
the
escexit_doco
branch
from
March 18, 2022 05:11
6e325d4
to
f122394
Compare
dploeger
requested changes
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Some small remarks.
Co-authored-by: Dennis Ploeger <[email protected]>
balloonpopper
commented
Mar 18, 2022
Updated @dploeger |
balloonpopper
commented
Mar 18, 2022
balloonpopper
force-pushed
the
escexit_doco
branch
from
March 18, 2022 10:51
df130df
to
3db051e
Compare
dploeger
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful. Thanks. 🎁
BHSDuncan
requested changes
Mar 18, 2022
Co-authored-by: Duncan Brown <[email protected]>
StraToN
approved these changes
Mar 21, 2022
BHSDuncan
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying when to use ESCexit instead of ESCitem.