-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reset audio bus layout #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it to gitignore as part of the change? I can't see any reason to have it commit if a developer makes a local change.
Hmm. We need this file. But putting it into .gitignore now would keep it in the history but just wouldn't record any new changes to it, right? And if you specifically want to record a change, you can force it. Never did it like this, but looks okay to me. I'd like your opinions on this, @BHSDuncan @StraToN |
I'm ok with how this PR handles it. It might seem unlikely, but if a developer decides to set his/her own defaults, it might be better not to have it in the .gitignore file. |
My Godot editor settings aren't considered part of this repository - when I change my Godot editor's font or other options they don't become a suggested commit - why should my local sound settings be any different? |
If I'm not mistaken (and I might be), these sound settings can potentially be used as the initial levels for a game (if the user doesn't want to create a new layout/resource for it), so it's a bit different than your local settings. Again, though, I may be mistaken. |
As we have decided yesterday, added the file to the gitignore with a comment on how to ignore it there. |
Thanks a lot !! 🥳 |
Apparently Godot stores the settings of the audio bus layout in the editor locally somewhere. We set "default audio bus layout" to the resource file in this commit and when starting up the auditor, Godot loads the bus layout setting and applies it to the resource file.
This is just to reset the layout to 0db for each channel. If any dev should've changed the layout in their editor, they should reset their layout as well.