Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset audio bus layout #542

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fix: Reset audio bus layout #542

merged 2 commits into from
Mar 17, 2022

Conversation

dploeger
Copy link
Collaborator

Apparently Godot stores the settings of the audio bus layout in the editor locally somewhere. We set "default audio bus layout" to the resource file in this commit and when starting up the auditor, Godot loads the bus layout setting and applies it to the resource file.

This is just to reset the layout to 0db for each channel. If any dev should've changed the layout in their editor, they should reset their layout as well.

Copy link
Collaborator

@balloonpopper balloonpopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to gitignore as part of the change? I can't see any reason to have it commit if a developer makes a local change.

@dploeger
Copy link
Collaborator Author

Can you add it to gitignore as part of the change? I can't see any reason to have it commit if a developer makes a local change.

Hmm. We need this file. But putting it into .gitignore now would keep it in the history but just wouldn't record any new changes to it, right? And if you specifically want to record a change, you can force it.

Never did it like this, but looks okay to me. I'd like your opinions on this, @BHSDuncan @StraToN

@BHSDuncan
Copy link
Collaborator

I'm ok with how this PR handles it. It might seem unlikely, but if a developer decides to set his/her own defaults, it might be better not to have it in the .gitignore file.

@balloonpopper
Copy link
Collaborator

My Godot editor settings aren't considered part of this repository - when I change my Godot editor's font or other options they don't become a suggested commit - why should my local sound settings be any different?
My thought : If the developer wants to commit their audio settings then let them update their own version of the .gitignore file - but I think the one attached to the demo repository should ignore local user-specific settings.

@BHSDuncan
Copy link
Collaborator

If I'm not mistaken (and I might be), these sound settings can potentially be used as the initial levels for a game (if the user doesn't want to create a new layout/resource for it), so it's a bit different than your local settings.

Again, though, I may be mistaken.

@dploeger
Copy link
Collaborator Author

As we have decided yesterday, added the file to the gitignore with a comment on how to ignore it there.

@StraToN StraToN merged commit e98209d into develop Mar 17, 2022
@StraToN StraToN deleted the audio-bus-layout branch March 17, 2022 22:09
@StraToN
Copy link
Collaborator

StraToN commented Mar 17, 2022

Thanks a lot !! 🥳

@dploeger dploeger restored the audio-bus-layout branch March 20, 2022 16:48
@dploeger dploeger deleted the audio-bus-layout branch March 20, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants