Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Graphics update for room 5 #525

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

balloonpopper
Copy link
Collaborator

image

Copy link
Collaborator

@BHSDuncan BHSDuncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just looking skimming through things.

Copy link
Collaborator

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Especially the use of particles.

Do we need to add anything about the licenses of the new pictures?

@balloonpopper
Copy link
Collaborator Author

I grabbed a couple of Kenney pictures for room 1 and added license details to the repository at the time to cover them.

Everything else I've drawn from scratch.
I don't have a licence requirement for my work, I'm trying to give back to the community.

If you feel it needs something, maybe give the copyright to the Escoria project and say it's under a "you're free to do whatever you like with it" license? 🤷

@dploeger
Copy link
Collaborator

dploeger commented Mar 4, 2022

I grabbed a couple of Kenney pictures for room 1 and added license details to the repository at the time to cover them.

Everything else I've drawn from scratch. I don't have a licence requirement for my work, I'm trying to give back to the community.

If you feel it needs something, maybe give the copyright to the Escoria project and say it's under a "you're free to do whatever you like with it" license? 🤷

Right. Then everything's fine. Thank you.

Copy link
Collaborator

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks! 🎁

@dploeger dploeger merged commit bcb366c into godot-escoria:develop Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants