feat: add gamepad support to escoria-ui-simplemouse #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StraToN
reviewed
Mar 1, 2022
bolinfest
force-pushed
the
rfc-gamepad-support
branch
2 times, most recently
from
0413244 to
0f204fd
Compare
bolinfest
changed the title
bolinfest
force-pushed
the
rfc-gamepad-support
branch
2 times, most recently
from
5e66361 to
2c16685
Compare
|
OK, rebased everything on |
|
I don't have a gamepad so I'm afraid I can't review this properly. Code looks good so far. |
StraToN
requested changes
Mar 3, 2022
|
@StraToN I looked through, but I'm unclear on which conversations still need to be resolved? |
bolinfest
force-pushed
the
rfc-gamepad-support
branch
from
2c16685 to
6cd148b
Compare
|
FYI, I just rebased on develop and updated this PR again, for good measure, though there were no merge conflicts. |
bolinfest
commented
Mar 4, 2022
bolinfest
force-pushed
the
rfc-gamepad-support
branch
from
d2e8cc1 to
fd73dfa
Compare
This was referenced Mar 7, 2022
bolinfest
force-pushed
the
rfc-gamepad-support
branch
from
fd73dfa to
f9226a0
Compare
StraToN
approved these changes
Mar 7, 2022
bolinfest
force-pushed
the
rfc-gamepad-support
branch
2 times, most recently
from
2a11e4a to
15c999e
Compare
|
Tested after rebase onto develop branch (to benefit fix from cb538ed). Keyboard plugin works fine. Gamepad in simple mouse works fine as well. All good to me, thanks a lot! |
bolinfest
force-pushed
the
rfc-gamepad-support
branch
from
15c999e to
ce212ac
Compare
This commit starts by introducing a new action, `ESC_UI_PRIMARY_ACTION`, that is used to represent a "primary action" from an input device, such as a left-click on a mouse or the press of the primary button on a gamepad. Although this action is not added to `InputMap` by default in `escoria-core`, `_unhandled_input()` in `esc_item.gd` is updated to look for it. The other portion of this commit is an update to `addons/escoria-ui-simplemouse/game.gd` that adds a gamepad mapping to the `InputMap` for both `ESC_UI_PRIMARY_ACTION` as well as another new action `ESC_UI_CHANGE_VERB_ACTION`. These actions are mapped to X and Y on an XBox controller, respectively. Note that `game.gd` is also updated to implement `_process()` such that moving `JOY_AXIS_0` and `JOY_AXIS_1` on "gamepad 0" will move the cursor around on the screen as the mouse would. Overall, this makes the game fairly playable with a gamepad, though admittedly a mouse is still currently required to click the "New game" button on the initial menu because `BaseButton::gui_input()` appears to be hardcoded to check for mouse events exclusively: https://github.com/godotengine/godot/blob/a09814e4f86861948615fcd83139de6ed9a34434/scene/gui/base_button.cpp#L55-L81
bolinfest
force-pushed
the
rfc-gamepad-support
branch
from
ce212ac to
54b116c
Compare
dploeger
approved these changes
Mar 14, 2022
StraToN
pushed a commit
that referenced
this pull request
Mar 14, 2022
This commit starts by introducing a new action, `ESC_UI_PRIMARY_ACTION`, that is used to represent a "primary action" from an input device, such as a left-click on a mouse or the press of the primary button on a gamepad. Although this action is not added to `InputMap` by default in `escoria-core`, `_unhandled_input()` in `esc_item.gd` is updated to look for it. The other portion of this commit is an update to `addons/escoria-ui-simplemouse/game.gd` that adds a gamepad mapping to the `InputMap` for both `ESC_UI_PRIMARY_ACTION` as well as another new action `ESC_UI_CHANGE_VERB_ACTION`. These actions are mapped to X and Y on an XBox controller, respectively. Note that `game.gd` is also updated to implement `_process()` such that moving `JOY_AXIS_0` and `JOY_AXIS_1` on "gamepad 0" will move the cursor around on the screen as the mouse would. Overall, this makes the game fairly playable with a gamepad, though admittedly a mouse is still currently required to click the "New game" button on the initial menu because `BaseButton::gui_input()` appears to be hardcoded to check for mouse events exclusively: godotengine/godot@a09814e/scene/gui/base_button.cpp#L55-L81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review stack (3/3) Prev
Updates escoria-ui-simplemouse to demonstrate basic gamepad support.
Addresses godot-escoria/escoria-issues#101.